kit/gmod-web-stream
1
0
Fork 0
Code Issues 17 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Skybox building materials overly bright after shader changes #43

New issue
Closed
opened 2026-03-19 15:23:23 +00:00 by kit · 0 comments
kit commented 2026-03-19 15:23:23 +00:00
Owner
Copy link

Problem

After the VMT shader type and envmap pipeline changes (commit 72e7fdf), some building materials in the 3D skybox appear overly bright compared to before. This is a lighting regression that needs investigation.

Likely causes

  • The placeholder cubemap (1x1 black) is initialized on all materials, which could affect materials that shouldn't have envmap reflections
  • The texture() function change (from textureCube()) in the shader might interact differently with Three.js's WebGL2 preprocessing
  • The envmap Fresnel formula correction (from inverted to correct) changes envmap contribution for surfaces that previously had near-zero envmap due to the broken formula

Steps to reproduce

Load gm_construct and compare the 3D skybox buildings (visible in the outdoor areas) against the ground truth screenshots.

## Problem After the VMT shader type and envmap pipeline changes (commit 72e7fdf), some building materials in the 3D skybox appear overly bright compared to before. This is a lighting regression that needs investigation. ## Likely causes - The placeholder cubemap (1x1 black) is initialized on all materials, which could affect materials that shouldn't have envmap reflections - The `texture()` function change (from `textureCube()`) in the shader might interact differently with Three.js's WebGL2 preprocessing - The envmap Fresnel formula correction (from inverted to correct) changes envmap contribution for surfaces that previously had near-zero envmap due to the broken formula ## Steps to reproduce Load gm_construct and compare the 3D skybox buildings (visible in the outdoor areas) against the ground truth screenshots.
kit closed this issue 2026-03-19 17:47:10 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
dev
feature/29-ragdoll-rendering
feature/23-reflection-clipping
feature/4-bsp-rendering
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
kit/gmod-web-stream#43
No description provided.